This repository was archived by the owner on Feb 18, 2025. It is now read-only.
If access to ORCHESTRATOR_API fails do not expose the password(s)#1319
Merged
shlomi-noach merged 2 commits intoopenark:masterfrom Mar 4, 2021
Merged
Conversation
Recently seen: orchestrator-client[10450]: Cannot access orchestrator at http://user:password@host.com/api. Check ORCHESTRATOR_API is configured correctly and orchestrator is running This exposes the password. Change to: orchestrator-client[10450]: Cannot access orchestrator at http://user:<REMOVED>@host.com/api. Check ORCHESTRATOR_API is configured correctly and orchestrator is running Also works if ORCHESTRATOR_API contains mulitple hostnames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently seen:
This exposes the password.
Change to:
Also works if
ORCHESTRATOR_APIcontains multiple hostnames.