This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Add .PutKVPairs() method to KVStore interface#1274
Merged
shlomi-noach merged 4 commits intoopenark:masterfrom Nov 24, 2020
Merged
Add .PutKVPairs() method to KVStore interface#1274shlomi-noach merged 4 commits intoopenark:masterfrom
shlomi-noach merged 4 commits intoopenark:masterfrom
Conversation
shlomi-noach
suggested changes
Nov 23, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
The addition of PutKVPairs() is good and makes sense. See inline a comment on how PutKVPairs() is used within orchestrator.go
Contributor
Author
|
Updated PR based on @shlomi-noach's suggestions |
shlomi-noach
approved these changes
Nov 24, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Looks good with minor suggested change.
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1273
Description
This PR adds the
.PutKVPairs()function to theKVStoreinterface (fromgo/kv/kv.go) to allow decisions around updating multiple KVs to be pushed down to the various KV store implementations. This new method replaces the single-KVPair method.PutKVPair()fromgo/kv/kv.goThe following files were updated to use
.PutKVPairs()vs single-KVPair updates:go/logic/command_applier.gogo/logic/orchestrator.gogo/logic/topology_recovery.goFor now the
.PutKVPairs()function in eachKVStoreis just doing a plain-loop over.PutKeyValue(). In the near-future this method will be used to implement atomic multi-KVPair updates for the Consul KV store (#1273) and potentially the Internal/ZooKeeper store, toocc @shlomi-noach