Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Issue #1259 Fix topology-related API endpoints for group replication setups#1263

Merged
shlomi-noach merged 1 commit intoopenark:masterfrom
ejortegau:master
Nov 8, 2020
Merged

Issue #1259 Fix topology-related API endpoints for group replication setups#1263
shlomi-noach merged 1 commit intoopenark:masterfrom
ejortegau:master

Conversation

@ejortegau
Copy link
Contributor

@ejortegau ejortegau commented Nov 7, 2020

Related issue: #1259

Description

This PR improves methods associated with serving the /topology.* endpoints so that replication groups are properly represented. For example, for a topology such as the one shown below:

image

the topology representation is now such that orchestrator-client shows this:

[ 10430 ] user@sabre ~/go/src/github.com/openark/orchestrator (master) % ➜  ./resources/bin/orchestrator-client -c topology -i sabre:5000
sabre:5020       [0s,ok,8.0.22,rw,ROW,>>,GTID]
+ sabre:5000     [0s,ok,8.0.22,rw,ROW,>>,GTID]
  ‡ sabre:5001 [0s,ok,8.0.22,ro,ROW,>>,GTID]
  ‡ sabre:5002 [0s,ok,8.0.22,ro,ROW,>>,GTID]
    + sabre:5010 [0s,ok,8.0.22,rw,ROW,>>,GTID]
+ sabre:5022     [0s,ok,8.0.22,rw,ROW,>>,GTID]
  + sabre:5021   [0s,ok,8.0.22,rw,ROW,>>,GTID]

Notice that we use the double dagger character ‡ to distinguish group replication from classical replication.

@shlomi-noach shlomi-noach merged commit b2e2f37 into openark:master Nov 8, 2020
@shlomi-noach shlomi-noach mentioned this pull request Nov 8, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shlomi-noach shlomi-noach shlomi-noach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ejortegau @shlomi-noach