This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Better analysis of UnreachableMaster#1225
Merged
shlomi-noach merged 2 commits intomasterfrom Aug 4, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement to
UnreachableMasteranalysis. Previously, when there was partial success probing a dead master, and at least some replicas were claiming to be replicating,orchestratorwould not issue an analysis.Now, however, if
orchestratorcannot see the master, even if there's partial success, and at least one replica is failing to connect to the master (while other replicas claim to be connected to the master), anUnreachableMasteranalysis is issued. That, in turn, will spawn emergent probing of 1st tier replicas to potentially identify aDeadMasterincident more quickly.