This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Recovery: relaxed promotion rule check searching for ideal replica#1222
Merged
shlomi-noach merged 2 commits intomasterfrom Jul 28, 2020
Merged
Recovery: relaxed promotion rule check searching for ideal replica#1222shlomi-noach merged 2 commits intomasterfrom
shlomi-noach merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current recovery logic has a mechanism to optimize recovery time on a dead master scenario:
prefer(ormust, which is yet unsupported) promotion rulethen, we we consider the replica as "ideal", immediately promote it as master, and asynchronously point the rest of replicas below it.
While analyzing a recent production use case, I noticed a setup where all servers were either marked as
neutralormust_not. None was marked withprefer. In that scenario, the recovery was not optimized.In this PR:
must_notpromotion rule