This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Skip Verify should be SSLSkipVerify Instead the mysql backend config.#1191
Merged
shlomi-noach merged 2 commits intoopenark:masterfrom Jun 14, 2020
Merged
Conversation
shlomi-noach
approved these changes
Jun 14, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Good catch. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Related issue: https://github.com/openark/orchestrator/issues/dev/null (couldn't create an issue :D)
Description
This PR fixes the configuration in the Raft http_client setup. Currently to skip the validation for raft SSL setup is with the variable MySQLOrchestratorSSLSkipVerify which should be used only to skip the validation against the MySQL backend for orchestrator. Instead, I have changed the variable for SSLSkipVerify which I guess is the right one.