This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Closed
Conversation
Collaborator
Author
|
#1175 replaces this PR. Closing without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new analysis entry aimed to identify a blocked semi-sync master situation.
Example scenario depicted in #1137
e.g. a master has a single semi-sync replica and a configuration of:
rpl_semi_sync_master_enabled=ONrpl_semi_sync_master_timeout=10000000000rpl_semi_sync_master_wait_for_slave_count=1if the semi-sync replica goes down, the master blocks writes. We want to identify this as a failure scenario (a recovery might be: enable semi-sync on a different replica).
However, we probably also want to make this detection only after some X seconds, because due to the nature of the setup, it may be normal for the master to block for 1 or 2 seconds occasionally.
The issue right now (which is why this PR is WIP at this time) is to be able to reliably say "the master has been blocked since 20sec ago". There's various ways to go about that, which I'm exploring.