This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Orchestrator systemd depency#1112
Merged
shlomi-noach merged 4 commits intoopenark:masterfrom Apr 8, 2020
Merged
Conversation
…th scheduled to start...
shlomi-noach
suggested changes
Apr 3, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
orchestrator might run with a SQLite backend, in which case it shouldn't wait on a MySQL server. Even with MySQL backend, it doesn't strictly have to run on same host as MySQL. So unfortunately I cannot merge this.
Just as an idea, how about systemd restarting orchestrator after failure, in 1min intervals?
Contributor
Author
|
Hey @shlomi-noach, This is why I used the From the systemd manual So I understand this as, this dependency is only enforced whenever both services are scheduled for start... Or do you think I'm interpreting it wrongly? |
Contributor
Author
|
Testing output to confirm my assumptions over the config file Installing latest orchestrator on an empty CentOS/7 vagrant machine Editing the service file to include this patch Verifying there is no MySQL service present: Verifying Orchestrator status before testing Reloading systemd to pick up my change Copying sample sqlite config and testing orchestrator |
Collaborator
|
@mcrauwel thank you! Any thoughts on #229 (comment) ? |
Contributor
Author
|
Adding link to my reply to the above mentioned comment. If we agree on moving this PR forward, I will run some extra test to ensure full compatibility on I will then also revert the documentation change that #1012 introduced as this will become obsolete. |
shlomi-noach
approved these changes
Apr 7, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Let's move forward
Contributor
Author
|
ubuntu test installing editing the service file checking mysql service starting testing mysql service |
Contributor
Author
|
MariaDB test |
Contributor
Author
|
Conclusion:
MariaDB responds to |
Contributor
Author
|
this change should cover all bases @shlomi-noach |
Collaborator
|
Closes #229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #229
Description
Adds a dependency so Orchestrator is only started AFTER MySQL if they are both schedule to start to avoid this behaviour: