This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Display region, data center, and environment in UI#1095
Merged
shlomi-noach merged 12 commits intoopenark:masterfrom Apr 29, 2020
Merged
Display region, data center, and environment in UI#1095shlomi-noach merged 12 commits intoopenark:masterfrom
shlomi-noach merged 12 commits intoopenark:masterfrom
Conversation
The region, data center, and physical environment bits of metadata are not currently displayed in the UI, though instances have a colored outline/border to distinguish DCs. This adds all 3 pieces of information to the instance modal window and also the title/tooltip for each instance in the cluster screen. (The latter has been tested on FF, Chrome, and Safari on OS X, but the embedded new lines may not work in all browsers.) This also adds a legend to the bottom of the cluster screen that shows the mapping of outline color to DC. Fixes openark#1094.
Contributor
Author
|
This is what it looks like:
|
Collaborator
|
Thank you for this pull request and sorry about the delays. This looks overall good and makes sense. I may tweak the UI a bit and circle back here. |
Collaborator
|
I'm suggesting this visual change:
In the above, the legend matches the cluster display format. |
shlomi-noach
approved these changes
Apr 28, 2020
Collaborator
shlomi-noach
left a comment
There was a problem hiding this comment.
Thank you for this PR. I've made some visual changes, as well as took anonymization and dc-coloring into account when rendering the legend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The region, data center, and physical environment bits of metadata are not currently displayed in the UI, though instances have a colored outline/border to distinguish DCs. This adds all 3 pieces of information to the instance modal window and also the title/tooltip for each instance in the cluster screen. (The latter has been tested on FF, Chrome, and Safari on OS X, but the embedded new lines may not work in all browsers.) This also adds a legend to the bottom of the cluster screen that shows the mapping of outline color to DC.
Fixes #1094.