This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Master failover: fix processes flow on PreFailoverProcesses failure#1044
Merged
shlomi-noach merged 2 commits intomasterfrom Jan 8, 2020
Merged
Master failover: fix processes flow on PreFailoverProcesses failure#1044shlomi-noach merged 2 commits intomasterfrom
shlomi-noach merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug seems to have been introduced recently, and this PR fixes it.
On a master failover, if any one of
PreFailoverProcessesfails, the entire failover operation should be aborted. This implies not running any post-failover processes.In the existing bug, the failover itself does not take place, but
PostUnsuccessfulFailoverProcessesdo get invoked.This PR fixes the situation.
cc @jfg956 who brought this to my attention in chat.