This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Supporting UnreachableIntermediateMasterWithLaggingReplicas#1005
Merged
shlomi-noach merged 6 commits intomasterfrom Nov 24, 2019
Merged
Supporting UnreachableIntermediateMasterWithLaggingReplicas#1005shlomi-noach merged 6 commits intomasterfrom
shlomi-noach merged 6 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999
This PR introduces the
UnreachableIntermediateMasterWithLaggingReplicasanalysis. As the name suggests, whenorchestratorcannot reach an intermediate master, and in addition all of its replicas are lagging -- this analysis is made.The remediation is similar to that of
UnreachableMasterWithLaggingReplicas:orchestratoremergently restarts replicationIO_threadon all replicas of said intermediate master.In scenarios like the one depicted in #999, the replicas then quick identify themselves to be broken. Thus, a next failure detection by
orchestratoris expected to analyze aDeadIntermediateMasterand kick a failover.cc @jfg956