chore: drop useless feature flags#8850
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42b604b35b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FeatureSpec { | ||
| id: Feature::PowershellUtf8, | ||
| key: "powershell_utf8", |
There was a problem hiding this comment.
Restore skills feature registration
The Feature::Skills enum is still used to gate skill loading (e.g., config.features.enabled(Feature::Skills) in codex.rs), but its FeatureSpec entry was removed from FEATURES. Because Features::with_defaults and feature_for_key only consult this list, Skills can no longer be enabled by defaults or by [features].skills in config, effectively disabling skills for all sessions. If skills are still intended to be available, re‑add the spec (or remove the gating and make skills unconditional).
Useful? React with 👍 / 👎.
…ure-flags # Conflicts: # codex-rs/core/src/tools/spec.rs
No description provided.