Skip to content

Add /edit external-editor workflow with command parsing, busy UI, and docs/tests updates#4147

Closed
honjo-hiroaki-gtt wants to merge 3 commits into
openai:mainfrom
honjo-hiroaki-gtt:feat/tui-edit-mode
Closed

Add /edit external-editor workflow with command parsing, busy UI, and docs/tests updates#4147
honjo-hiroaki-gtt wants to merge 3 commits into
openai:mainfrom
honjo-hiroaki-gtt:feat/tui-edit-mode

Conversation

@honjo-hiroaki-gtt

Copy link
Copy Markdown
  • this follows collaborator feedback in PR #3044, comment 3309270038, which suggested adding a keyboard shortcut to open the current prompt in $EDITOR
  • introduce /edit slash command and Ctrl+E shortcut that resolve $VISUAL$EDITOR → OS fallback and safely round-trip the composer through an external editor (--send, --new, --keep size limit, kill switch)
  • integrate the workflow with the TUI: preserve attachments when reloading, surface inline busy state while waiting on the editor, and gate the feature behind CODEX_EDIT_DISABLE
  • factor command parsing via SlashCommandInvocation, update ChatWidget dispatch, and keep composer placeholders in sync
  • update README/config docs and extend unit tests (slash command parsing, external editor mock paths); cargo test -p codex-tui passes locally

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Comment thread codex-rs/tui/src/external_editor.rs Outdated
@etraut-openai

Copy link
Copy Markdown
Collaborator

Thanks for the contribution, and apologies for the slow response. We've received many PRs, and we don't have the bandwidth on the codex team to review all of them.

We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 31, 2025
@openai openai unlocked this conversation Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants