Add extra config to StoredThread, leave empty for now#27092
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 211daa85d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permission_profile_from_metadata_value(&metadata.sandbox_policy, metadata.cwd.as_path()); | ||
| StoredThread { | ||
| thread_id: metadata.id, | ||
| extra_config: None, |
There was a problem hiding this comment.
Preserve extra config in local thread reads
When a caller starts a session with config.extra_config = Some(...), Session now passes it into CreateThreadParams, but the default local store reconstructs every StoredThread with extra_config: None. That makes the new StoredThread.extra_config field observable only in the in-memory test store and drops it for real persisted threads after any read/list/resume path, so consumers cannot rely on the field surviving thread creation.
Useful? React with 👍 / 👎.
No description provided.