Skip to content

Show effective sandbox modes in /debug-config#27068

Merged
canvrno-oai merged 3 commits into
mainfrom
codex/debug-config-effective-sandbox-modes
Jun 9, 2026
Merged

Show effective sandbox modes in /debug-config#27068
canvrno-oai merged 3 commits into
mainfrom
codex/debug-config-effective-sandbox-modes

Conversation

@canvrno-oai

@canvrno-oai canvrno-oai commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Render /debug-config's allowed_sandbox_modes from the finalized permission constraints instead of the raw requirements list.
  • Add regression coverage for configured full-access and external sandbox modes being omitted when effective permissions reject them.

Details

allowed_sandbox_modes comes from managed requirements, but the final permissions can be further constrained by derived validation rules. For example, permissions.filesystem.deny_read requires sandbox enforcement, so modes that disable or externalize Codex's sandbox are not actually usable even if they were present in the raw requirements TOML.

The debug renderer now enumerates the configured sandbox-mode labels and keeps only those accepted by Config.permissions. That makes /debug-config reflect the same effective permission-profile constraint path used by runtime config validation, while preserving the existing source/provenance display.

Validation

  • Added a regression test for effective sandbox-mode filtering in /debug-config.

@canvrno-oai canvrno-oai force-pushed the codex/debug-config-effective-sandbox-modes branch from f0e871a to c84c6bb Compare June 8, 2026 21:45
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aef829d185

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/debug_config.rs
@canvrno-oai canvrno-oai marked this pull request as ready for review June 8, 2026 22:49
@canvrno-oai canvrno-oai changed the title Show effective sandbox modes in debug config Show effective sandbox modes in /debug-config Jun 8, 2026

@fcoury-oai fcoury-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to review how /debug-config would read before and after this change and it works as expected.

I think the updated response seems to better reflect the actual current status.

Approved 👍

@canvrno-oai canvrno-oai merged commit 8534912 into main Jun 9, 2026
31 checks passed
@canvrno-oai canvrno-oai deleted the codex/debug-config-effective-sandbox-modes branch June 9, 2026 00:03
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants