Skip to content

[codex-analytics] stop sending codex error subreason#27060

Merged
rhan-oai merged 1 commit into
mainfrom
rhan/codex-error-subreason
Jun 8, 2026
Merged

[codex-analytics] stop sending codex error subreason#27060
rhan-oai merged 1 commit into
mainfrom
rhan/codex-error-subreason

Conversation

@rhan-oai

@rhan-oai rhan-oai commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • stop emitting codex_error_subreason on codex_turn_event
  • remove the transient analytics fact plumbing that copied CodexErr::InvalidRequest(String) into the event
  • update analytics serialization coverage accordingly

Why

codex_error_subreason is a free-form copy of InvalidRequest(String), including raw provider 400 bodies in some paths. That makes it unsafe as an analytics field because it may carry user-derived or sensitive text. All data from this field is being completely dropped.

Validation

  • just fmt
  • just test -p codex-analytics

@rhan-oai rhan-oai marked this pull request as ready for review June 8, 2026 21:12
@rhan-oai rhan-oai changed the title Stop sending codex error subreason [codex-analytics] stop sending codex error subreason Jun 8, 2026
@rhan-oai rhan-oai enabled auto-merge (squash) June 8, 2026 21:23
@rhan-oai rhan-oai merged commit ee6c91d into main Jun 8, 2026
31 checks passed
@rhan-oai rhan-oai deleted the rhan/codex-error-subreason branch June 8, 2026 21:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants