Load plugin hooks without other plugin capabilities#26272
Merged
Conversation
zanie-oai
approved these changes
Jun 4, 2026
fcoury-oai
approved these changes
Jun 4, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Very good improvement here, thank you.
Smoke-tested hooks/list with an enabled plugin that had a valid hook plus intentionally malformed MCP/app configs; it returned the plugin hook and did not load or warn on the unrelated malformed capabilities.
Code also looks good, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/listonly consumes plugin hook declarations, but previously loaded every enabled plugin's skills, MCP configuration, apps, and capability summary before discarding them.In a local benchmark, this reduced
hooks/listlatency by over 100ms (e.g., from 594 to 467ms on startup, and 168 to 16ms when making ahooks/listcall later in the same TUI session). This is on the critical path to rendering the TUI, so every 10s of ms should be eyed skeptically (IMO).This change adds a hook-specific plugin loading path that preserves plugin enablement, remote/local conflict resolution, deterministic ordering, manifest resolution, and hook-loading warnings while skipping unrelated capabilities. (I think there's room for a more general design here that allows you to project the capabilities you need at load-time, but that seems unnecessary right now.)