Use Windows setup marker as completion signal#26074
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21cce60ea3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review again |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59eeb54a26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Why
When an organization requires the elevated Windows sandbox, Codex launches an elevated helper to provision users, configure firewall and ACL rules, and lock persistent sandbox directories.
We observed that closing the helper after setup started could leave the machine partially initialized while the TUI still announced Sandbox ready. Model-only turns continued to work, but the first shell command retried setup and failed with Windows cancellation error
1223.This was not an enforcement bypass; command execution continued to fail closed. The issue was a false readiness signal:
setup_marker.jsonwas written during user provisioning, before the remaining setup stages had completed.What
Treat
setup_marker.jsonas the commit record for Windows sandbox setup:If setup is canceled or fails, the marker remains invalid and Codex reports setup as incomplete instead of announcing readiness.
Refresh-only and read-ACL-only helper runs continue to leave the marker untouched. The setup version remains
5to avoid forcing all existing Windows users through elevated setup again.Verification
just test -p codex-windows-sandbox.