[codex] Fix Windows BuildBuddy Bazel wrapper execution#25915
Merged
Conversation
e10633e to
87b61d0
Compare
6af0501 to
0f35529
Compare
bolinfest
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#25156 moved Bazel CI launches into a shared Python wrapper. On Windows, launching Bazel with
os.execvpcan split the spaced--test_env=PATH=...argument and fail to propagate the eventual Bazel exit status, allowing jobs to pass without running tests. This reapplies the wrapper after #25909 with a Windows-safe launch path.What changed
Use a waited
subprocess.runlaunch on Windows while preservingos.execvpon Unix. Add a process-level regression test for spaced arguments and child exit status, and run it on Windows Bazel shard 1.Experiment
To confirm Bazel was actually invoking tests, patch
87b61d0be6temporarily added an intentionally failingcodex-coreunit test. Bazel failed on that sentinel on all three major platforms:The sentinel was removed after collecting this evidence. Windows Bazel clippy and release verification also passed.
Validation
After removing the sentinel,
just test -p codex-coreno longer reported it. The local run retained two unrelated environment-specific failures.