Run Codex async main on a sized stack#25847
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
approved these changes
Jun 2, 2026
anp-oai
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, one alternative might be to set the initial thread stack size with linker args but this has the advantage of being spelled the same for bazel and cargo and the expense of an extra thread is probably not a big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Runtime::block_onexecutes the top-level future on the caller's OS thread, not on one of Tokio's worker threads. That matters for the interactive CLI because the Tokio runtime already configures larger worker stacks, while the process main thread can still have a smaller platform default stack.This showed up as a
/clearcrash on macOS: starting a fresh TUI thread reloads config, and the stack-heavy TOML deserialization path can overflow before the new session is actually started.What Changed
arg0_dispatch_or_elseasync entrypoint on a namedcodex-mainthread.TOKIO_WORKER_STACK_SIZE_BYTESstack budget already used for Tokio worker threads.Arg0DispatchPathsand the arg0 alias guard lifetime behavior the same.Verification
cargo check -p codex-clicurrently fails because the top-level CLI/TUI future is notSendunder the new thread boundary.