[codex] fix compressed rollout fixture SessionMeta initialization#25628
Merged
Conversation
jif-oai
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parent_thread_idin the compressed rollout test fixture'sSessionMetaRoot cause
PR #25087 (
Read compressed rollouts and materialize before append) addedcodex-rs/rollout/src/compression_tests.rsin merge commita8a6071279b6f3112fcc5fc3fee69c48473d7149. Itswrite_rolloutfixture constructsSessionMetawithout the requiredparent_thread_idfield, causingerror[E0063]when Bazel compilesrollout-unit-tests-binonmainand downstream PRs.Validation
UV_CACHE_DIR=/private/tmp/codex-uv-cache just fmtjust test -p codex-rollout(59tests passed; bench smoke passed)git diff --checkLocal lint blocker
just argument-comment-lintcould not reach source inspection locally because Bazel's LLVM dependency fails analysis:compiler-rt/BUILD.bazelglobinclude/sanitizer/*.hmatched no files.