Skip to content

[codex] fix compressed rollout fixture SessionMeta initialization#25628

Merged
jif-oai merged 1 commit into
mainfrom
codex/fix-rollout-session-meta-parent-thread-id
Jun 1, 2026
Merged

[codex] fix compressed rollout fixture SessionMeta initialization#25628
jif-oai merged 1 commit into
mainfrom
codex/fix-rollout-session-meta-parent-thread-id

Conversation

@fcoury-oai

Copy link
Copy Markdown
Contributor

Summary

  • initialize parent_thread_id in the compressed rollout test fixture's SessionMeta
  • restore rollout test compilation across Bazel test, clippy, release-build, and argument-comment-lint jobs

Root cause

PR #25087 (Read compressed rollouts and materialize before append) added codex-rs/rollout/src/compression_tests.rs in merge commit a8a6071279b6f3112fcc5fc3fee69c48473d7149. Its write_rollout fixture constructs SessionMeta without the required parent_thread_id field, causing error[E0063] when Bazel compiles rollout-unit-tests-bin on main and downstream PRs.

Validation

  • UV_CACHE_DIR=/private/tmp/codex-uv-cache just fmt
  • just test -p codex-rollout (59 tests passed; bench smoke passed)
  • git diff --check
  • manually audited the touched Rust diff for positional literal argument comments; the change adds no positional callsite

Local lint blocker

  • just argument-comment-lint could not reach source inspection locally because Bazel's LLVM dependency fails analysis: compiler-rt/BUILD.bazel glob include/sanitizer/*.h matched no files.

@fcoury-oai fcoury-oai marked this pull request as ready for review June 1, 2026 14:41
@jif-oai jif-oai merged commit 4eded02 into main Jun 1, 2026
31 checks passed
@jif-oai jif-oai deleted the codex/fix-rollout-session-meta-parent-thread-id branch June 1, 2026 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants