fix(tui): add reasoning effort fallback shortcuts#25623
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4adc657e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b4adc65 to
fbc167b
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16662c4c73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
left a comment
There was a problem hiding this comment.
Tested locally and verified fix.
I like the new functionality, but I think the implementation is way more verbose than necessary and will create maintainability problems going forward.
I've taken a stab at putting it on a diet in this draft PR that builds upon this one. I created this by using my $simplify-code skill and really pushing on the agent to look for ways to simplify.
|
@codex review |
4374ddf to
a992197
Compare
a992197 to
bc6f8fb
Compare
Why
The default reasoning-effort shortcuts use
Alt+,andAlt+., but macOS Terminal.app does not deliver those bindings unless the active profile has "Use Option as Meta key" enabled. This leaves the quick reasoning-effort controls unavailable with the default Terminal.app profile.Closes #25429.
What Changed
Alt+,andAlt+.as the existing reasoning-effort shortcuts.Shift+DownandShift+Upas fallback shortcuts for decreasing and increasing reasoning effort./keymap.How to Test
Shift+Upand confirm that reasoning effort increases.Shift+Downand confirm that reasoning effort decreases./keymapand confirm that the reasoning-effort actions list the Shift-arrow fallbacks alongside the existing Alt bindings.Alt+.andAlt+,still adjust reasoning effort.Targeted tests:
just test -p codex-tui defaults_include_reassignable_main_surface_actionsjust test -p codex-tui shortcuts_just test -p codex-tui 'keymap_setup::tests::picker_'