Export Guardian prompt cache key helper#24892
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e191176f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub(crate) use review::routes_approval_to_guardian; | ||
| pub(crate) use review::spawn_approval_request_review; | ||
| pub(crate) use review_session::GuardianReviewSessionManager; | ||
| pub(crate) use review_session::prompt_cache_key_override_for_review_session; |
There was a problem hiding this comment.
Add the helper before re-exporting it
This re-export makes codex-core fail to compile when this split PR is built by itself: repo-wide search in this commit finds no prompt_cache_key_override_for_review_session definition in review_session (or elsewhere), so Rust reports an unresolved import here. If the helper lives in a companion PR, this commit needs to include that definition or avoid exporting it until the dependency lands.
Useful? React with 👍 / 👎.
Split from the Guardian prompt cache key change. This PR only updates codex-rs/core/src/guardian/mod.rs. Validation was not run per request; this branch is expected to rely on the companion split PRs.