fix(tui): improve markdown table column allocation#24346
Merged
Conversation
etraut-openai
approved these changes
May 25, 2026
etraut-openai
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a reasonable heuristic to address this problem.
Code looks good.
I built locally and compared before and after, and the fix appears to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Markdown tables with a long path-heavy column could allocate almost all available width to that column and collapse neighboring prose columns to only a few characters. In rollout summaries this made
UnitandWhat It Addsdifficult to read, even though the longFilesvalues were the content best suited to wrapping.The affected example also specified
Filesas right aligned in its markdown delimiter (---:). This change preserves that requested alignment while improving how width is distributed.What Changed
How to Test
Unit, right-alignedFiles,Adds,Removes, andWhat It Addscolumns at a constrained terminal width.Filesand sentence-length content inUnitandWhat It Adds.Filesremains right aligned but wraps before the narrative columns become unreadable.Targeted tests:
just test -p codex-tui markdown_renderValidation note:
just test -p codex-tuiwas also attempted and reached two existing unrelated failures inapp::tests::update_feature_flags_disabling_guardian_*; the markdown rendering regression test passes in the targeted run.