Add forked_from_thread_id turn metadata#24160
Merged
Merged
Conversation
458564d to
9051b29
Compare
This was referenced May 26, 2026
f4a05f8 to
8287c25
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8287c259e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
approved these changes
May 26, 2026
jif-oai
left a comment
Collaborator
There was a problem hiding this comment.
Most enterprise proxy reject _ in headers or metadata. Could we use - instead please?
| extensions: Arc::clone(&parent_session.services.extensions), | ||
| conversation_history: initial_history.unwrap_or(InitialHistory::New), | ||
| session_source: SessionSource::SubAgent(subagent_source.clone()), | ||
| forked_from_thread_id: None, |
Collaborator
There was a problem hiding this comment.
Should this really be none here? Shouldn't we use the parent thread for reviews?
2682fb1 to
65f6b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When Codex calls responsesapi, we currently send
session_id,thread_id, andturn_idamong other things asclient_metadata["x-codex-turn-metadata"]. This PR addsforked_from_thread_idwhich helps explain the "lineage" of a forked thread.What's changed
forked_from_thread_idin Codex turn metadata while preventing turn-scoped Responses API client metadata from overwriting Codex-owned lineage fields.