Skip to content

Avoid config snapshots in live agent subtree traversal#24057

Merged
jif-oai merged 2 commits into
mainfrom
codex/feedback-live-subtree-index
May 22, 2026
Merged

Avoid config snapshots in live agent subtree traversal#24057
jif-oai merged 2 commits into
mainfrom
codex/feedback-live-subtree-index

Conversation

@jif-oai

@jif-oai jif-oai commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Why

/feedback asks ThreadManager for the selected agent subtree before it uploads logs. The previous live subtree path reconstructed parent-child links by iterating every loaded thread and awaiting each thread config snapshot, so unrelated loaded-thread state could stall feedback subtree enumeration.

The loaded-thread set already belongs to ThreadManagerState. Reading thread-spawn parents from the captured CodexThread session sources at that boundary keeps unload and resume behavior manager-owned while avoiding per-session config inspection.

What Changed

  • expose parent-child thread-spawn edges for loaded, non-internal threads from ThreadManagerState
  • build the live child map from those edges while keeping agent metadata lookup and ordering in AgentControl
  • add regression coverage for live subtree enumeration when no state DB is available

Validation

  • git diff --check
  • local Rust tests not run per request

@jif-oai jif-oai changed the title [codex] Use registry for live agent subtree traversal [codex] Avoid config snapshots in live agent subtree traversal May 22, 2026
@jif-oai jif-oai changed the title [codex] Avoid config snapshots in live agent subtree traversal Avoid config snapshots in live agent subtree traversal May 22, 2026
@jif-oai jif-oai marked this pull request as ready for review May 22, 2026 10:48
@jif-oai jif-oai requested a review from a team as a code owner May 22, 2026 10:48
@jif-oai

jif-oai commented May 22, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 5865ec4 into main May 22, 2026
31 checks passed
@jif-oai jif-oai deleted the codex/feedback-live-subtree-index branch May 22, 2026 11:06
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants