Add thread/settings/update app-server API#23502
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0f3b950fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0169c2f4cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
There was a problem hiding this comment.
Codex found one medium severity issue. I smoke tested the happy path and it worked as expected.
Code also looks good so I am approving this and leaving the feedback addressing at your criteria.
Why
App-server clients need a way to update a thread's next-turn settings without starting a turn, adding transcript content, or waiting for turn lifecycle events. This gives settings UI a direct path for durable thread settings while clients observe the eventual effective state through a notification.
This is a simplified rework of PR #22509. In particular, it changes the
thread/settings/updateapi to return immediately rather than waiting and returning the effective (updated) thread settings. This makes the new api consistent withturn/startand greatly reduces the complexity of the implementation relative to the earlier attempt.What Changed
thread/settings/updatewith partial-update request fields and an empty acknowledgment response.thread/settings/updated, carrying full effectiveThreadSettingsand scoped bythreadIdto subscribed clients for the affected thread.turn/start, includingsandboxPolicypluspermissionsrejection andserviceTier: nullclearing.turn/startoverrides change the stored effective thread settings.app-server/README.md.