[codex] Use compaction_trigger item for remote compaction v2#22809
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote compaction v2 was still using
context_compactionas both the request trigger and the compacted output shape. The Responses API now has the landed contract for this flow: Codex sends a dedicated{ "type": "compaction_trigger" }input item, and the backend returns the standardcompactionoutput item with encrypted content.This aligns the v2 path with that wire contract while preserving the existing local compacted-history post-processing behavior.
What changed
ResponseItem::CompactionTriggerand regenerate the app-server protocol schema fixtures.compaction_triggerfromremote_compaction_v2instead of a payload-lesscontext_compaction.compactionoutput item, then reuse the existing compacted-history rebuilding path.Verification
cargo test -p codex-protocol compaction_triggercargo test -p codex-core remote_compact_v2cargo test -p codex-core compact_remote_v2cargo test -p codex-core responses_websocket_sends_response_processed_after_remote_compaction_v2just write-app-server-schemacargo test -p codex-app-server-protocol schema_fixtures