Defer startup NUX impressions until startup succeeds#22587
Merged
Conversation
canvrno-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a follow-up to #22573. This problem was surfaced in a code review comment that I missed before merging the previous PR.
Fresh-session startup could prepare a model-availability NUX before
app_server.start_thread(&config)completed. If thread startup then failed, the TUI never rendered the tooltip, butprepare_startup_tooltip_override(...)had already persisted one of the limited impressions.What Changed
start_thread(...)succeeds.should_prepare_startup_tooltip_override(...)helper and its gate test.