tests: avoid ambient temp sandbox roots#22576
Merged
starr-openai merged 2 commits intoMay 14, 2026
Merged
Conversation
pakrym-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some sandboxed integration tests enabled both ambient temp roots (
TMPDIRand literal/tmp) even though they were not testing temp-root behavior. On Linux bwrap, making/tmpwritable causes protected metadata mount targets such as/tmp/.git,/tmp/.agents, and/tmp/.codexto be synthesized. If a run is interrupted, those top-level markers can be left behind and contaminate later tests.What changed
For the incidental integration tests that do not need ambient temp-root access, set
exclude_tmpdir_env_varandexclude_slash_tmptotrue. Dedicated protected-metadata coverage remains in the lower-level sandbox tests that use isolated temp roots.Verification
Focused remote devbox repros passed with a watcher polling
/tmp/.git,/tmp/.agents, and/tmp/.codex; no leaked markers were observed.