Skip to content

feat: move extension scope ids into ExtensionData#22490

Merged
jif-oai merged 2 commits into
mainfrom
codex/extension-data-level-id
May 13, 2026
Merged

feat: move extension scope ids into ExtensionData#22490
jif-oai merged 2 commits into
mainfrom
codex/extension-data-level-id

Conversation

@jif-oai

@jif-oai jif-oai commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a scoped level_id to ExtensionData and expose it through level_id()
  • remove thread_id/turn_id parameters from extension contributor inputs where the scoped ExtensionData already carries that identity
  • move turn-scoped extension data onto TurnContext so token usage and lifecycle contributors can share the same turn store

Testing

  • cargo check -p codex-extension-api -p codex-core --tests
  • cargo test -p codex-extension-api
  • cargo test -p codex-guardian
  • cargo test -p codex-core --lib record_token_usage_info_notifies_extension_contributors
  • cargo test -p codex-core --lib submission_loop_channel_close_emits_thread_stop_lifecycle
  • cargo test -p codex-core --lib submission_loop_channel_close_aborts_active_turn_before_thread_stop_lifecycle
  • just fix -p codex-extension-api
  • just fix -p codex-guardian
  • just fix -p codex-core
  • just fmt

Note

  • Attempted cargo test -p codex-core; it aborted in agent::control::tests::spawn_agent_fork_last_n_turns_keeps_only_recent_turns with the existing stack overflow before the full suite completed.

@jif-oai jif-oai changed the title [codex] Move extension scope ids into ExtensionData feat: move extension scope ids into ExtensionData May 13, 2026
@jif-oai

jif-oai commented May 13, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@jif-oai jif-oai marked this pull request as ready for review May 13, 2026 13:46
@jif-oai jif-oai requested a review from a team as a code owner May 13, 2026 13:46
@jif-oai

jif-oai commented May 13, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 1dcc89f into main May 13, 2026
27 checks passed
@jif-oai jif-oai deleted the codex/extension-data-level-id branch May 13, 2026 14:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant