feat(tui): standardize picker navigation keys#22347
Merged
Merged
Conversation
canvrno-oai
approved these changes
May 13, 2026
canvrno-oai
left a comment
Contributor
There was a problem hiding this comment.
Smoke tested in TUI client, did not observe any issues.
etraut-openai
approved these changes
May 13, 2026
etraut-openai
left a comment
Collaborator
There was a problem hiding this comment.
The config code (in core) looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Picker-style UI in the TUI has accumulated a mix of hardcoded navigation keys. Some lists supported page movement, some did not; some accepted Vim-like keys, while others only accepted arrows; and tabbed or horizontally adjustable pickers had no shared keymap action for left/right movement.
This PR makes picker/list navigation consistent and configurable so users can rely on the same defaults across the TUI.
What Changed
move_up,move_downmove_left,move_rightpage_up,page_down,jump_top,jump_bottomCtrl+P/N,Ctrl+K/J, and plaink/jwhere text input is not activePageUp/PageDownandCtrl+B/FHome/EndLeft/RightandCtrl+H/LHow to Test
Ctrl+J/Kmoves the selection down/up.Ctrl+F/Bpages down/up andHome/Endjumps to the first/last visible session.jorkand confirm it updates the query instead of navigating.Ctrl+H/Lchanges the focused value like left/right arrows.Targeted tests run:
cargo test -p codex-tui keymap::tests::cargo test -p codex-tui keymap_setup::tests::cargo test -p codex-tui horizontal_list_keyscargo test -p codex-tui page_and_jump_navigation_use_list_keymapcargo test -p codex-tui ctrl_h_l_move_provider_selectioncargo test -p codex-tui scroll_state::testscargo test -p codex-tui switching_tabs_changes_visible_items_and_clears_searchcargo test -p codex-tui toggle_sort_key_reloads_with_new_sortAlso ran
just write-config-schema,just fmt,just fix -p codex-tui,just argument-comment-lint, andgit diff --check.Note:
cargo test -p codex-tuiwas attempted and still aborts in the pre-existingtests::fork_last_filters_latest_session_by_cwd_unless_show_allstack overflow, which is unrelated to this branch.