[exec-server] serve websocket listener via HTTP upgrade#21963
Merged
Conversation
7cc55f4 to
6f40914
Compare
This was referenced May 10, 2026
| Self::from_websocket_parts(websocket_writer, websocket_reader, connection_label) | ||
| } | ||
|
|
||
| pub(crate) fn from_axum_websocket(stream: AxumWebSocket, connection_label: String) -> Self { |
Collaborator
Author
There was a problem hiding this comment.
still used, my local git state was a bit confused, fixed
This reverts commit 81f5eab.
43b6890 to
cb75189
Compare
starr-openai
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex exec-servershould keep the existing publicws://IP:PORTURL shape while serving that websocket connection through an HTTP upgrade path internally. That keeps the client-facing configuration simple and allows the listener to work through intermediate HTTP-aware infrastructure.What changed
ws://IP:PORT/GET /readyzfrom the same listener for readiness checksVerification
cargo test -p codex-exec-server --test health --test process --test websocket --test initialize --test exec_process