Reapply "Move skills watcher to app-server"#21652
Merged
pakrym-oai merged 5 commits intoMay 9, 2026
Merged
Conversation
78a2064 to
b493bf4
Compare
This was referenced May 8, 2026
41cfe51 to
4f83154
Compare
bolinfest
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #21460 reverted the earlier move of skills change watching from
codex-coreinto app-server. This reapplies that boundary change so app-server owns client-facingskills/changednotifications and core no longer carries the watcher.What
SkillsWatcherand register it from thread listener setup.skills/changednotifications after a watched skill file changes.Validation
cargo test -p codex-app-server --test all suite::v2::skills_list::skills_changed_notification_is_emitted_after_skill_change -- --exact --nocapturecargo test -p codex-core --lib --no-run