[codex] make shutdown pending-touch test deterministic#21550
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
shutdown_flushes_pending_metadata_irrelevant_updated_atto seed an existing pendingupdated_attouch directly inRolloutWriterStateWhy
The old test had to complete several async operations inside the 50 ms test-only coalescing window. When that sequence took longer, the second flush updated
threads.updated_atimmediately and the pre-shutdown equality assertion failed, even though shutdown behavior was correct.Validation
cargo test -p codex-rollout shutdown_flushes_pending_metadata_irrelevant_updated_atcargo test -p codex-rollout