test: isolate app-server-client in-process test state#21328
Merged
Conversation
aibrahim-oai
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The in-process
app-server-clienttests were still building their configs from the ambientcodex_homeand letting the embedded app server create its own state DB whenstate_dbwas absent. That matters because in-process startup falls back toinit_state_db_from_config(...)in that case, so tests can otherwise share persisted state instead of getting isolated fixtures:app-server/src/in_process.rs.What changed
codex_home.TestClientwrapper.tempfileas a dev dependency for the new harness.The updated setup lives in
app-server-client/src/lib.rs.Testing
codex-app-server-clienttests continue to exercise the updated in-process client path through the isolated helper.