Skip to content

Remove core MCP list tools op#21281

Merged
pakrym-oai merged 3 commits into
mainfrom
pakrym/drop-list-mcp-tools-op
May 6, 2026
Merged

Remove core MCP list tools op#21281
pakrym-oai merged 3 commits into
mainfrom
pakrym/drop-list-mcp-tools-op

Conversation

@pakrym-oai

Copy link
Copy Markdown
Collaborator

Why

The core Op::ListMcpTools request path is no longer needed. Keeping it around left a dead request/response surface alongside the app-server MCP inventory APIs that own current server status listing.

What Changed

  • Removed Op::ListMcpTools, EventMsg::McpListToolsResponse, and the core handler that built the MCP snapshot response.
  • Removed the now-unused codex-mcp snapshot wrapper/export and passive event handling arms in rollout and MCP-server consumers.
  • Updated tests that used the old op as a synchronization hook to wait on existing startup/skills events, and deleted the plugin test that only exercised the removed listing op.

Validation

  • cargo test -p codex-protocol
  • cargo test -p codex-mcp
  • cargo test -p codex-rollout -p codex-rollout-trace -p codex-mcp-server
  • cargo test -p codex-core --test all pending_input::queued_inter_agent_mail
  • cargo test -p codex-core --test all rmcp_client::stdio_mcp_tool_call_includes_sandbox_state_meta
  • cargo test -p codex-core --test all rmcp_client::stdio_image_responses
  • just fix -p codex-core -p codex-protocol -p codex-mcp -p codex-rollout -p codex-rollout-trace -p codex-mcp-server

@pakrym-oai pakrym-oai marked this pull request as ready for review May 6, 2026 01:13
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 6, 2026 01:13
@pakrym-oai pakrym-oai enabled auto-merge (squash) May 6, 2026 18:19
@pakrym-oai pakrym-oai merged commit 712305b into main May 6, 2026
37 of 38 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/drop-list-mcp-tools-op branch May 6, 2026 18:20
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants