Move installation ID resolution out of core startup#21182
Conversation
Resolve or inject installation IDs at the host boundary and pass them into ThreadManager and Session as plain Strings. This removes filesystem access from the core session startup path, keeps spawned children on the same installation ID, and propagates startup failures without panicking in mcp-server. Validation: - just fix -p codex-core -p codex-core-api -p codex-app-server -p codex-mcp-server -p codex-thread-manager-sample - just fmt - cargo test -p codex-mcp-server - cargo test -p codex-core --test all includes_conversation_id_and_model_headers_in_request - cargo test -p codex-core --test all chatgpt_auth_sends_correct_request - cargo test -p codex-core --test all prefers_apikey_when_config_prefers_apikey_even_with_chatgpt_tokens - cargo test -p codex-core --test all list_skills_skips_cwd_roots_when_environment_disabled - cargo test -p codex-core --test all with_additional_permissions_requires_approval_under_on_request - cargo test -p codex-core thread_manager::tests::explicit_installation_id_skips_codex_home_file Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 540a678365
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cb15b37eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ThreadManager,CodexSpawnArgs, andSessionas a plainStringmcp-serverinstead of panickingWhy
Core was still touching the filesystem on the session startup path to discover
installation_id. This moves that work to the outer host boundary so core no longer depends oncodex_homereads during session construction.