tui: retire /approvals and rename /autoreview to /approve#21034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI currently exposes overlapping command names for the same permissions flow:
/permissionsand the older/approvalsalias. It also uses/autoreviewfor the manual retry flow, even though the action users take there is approving one denied auto-review request.This change makes the command surface consistent with the hard rebrand:
/permissionsis the only command for permission settings./approveis the command for approving a recent auto-review denial.What changed
/approvalsslash command and its dispatch path./permissionsas the single permissions command shown and accepted by the TUI./autoreviewto/approve./permissionsrather than the retired/approvalsname.Verification
AutoReviewnow renders and parses asapprove.