Skip to content

tui: retire /approvals and rename /autoreview to /approve#21034

Merged
won-openai merged 1 commit into
mainfrom
approvalremove
May 4, 2026
Merged

tui: retire /approvals and rename /autoreview to /approve#21034
won-openai merged 1 commit into
mainfrom
approvalremove

Conversation

@won-openai

Copy link
Copy Markdown
Collaborator

Why

The TUI currently exposes overlapping command names for the same permissions flow: /permissions and the older /approvals alias. It also uses /autoreview for the manual retry flow, even though the action users take there is approving one denied auto-review request.

This change makes the command surface consistent with the hard rebrand:

  • /permissions is the only command for permission settings.
  • /approve is the command for approving a recent auto-review denial.

What changed

  • Removed the legacy /approvals slash command and its dispatch path.
  • Kept /permissions as the single permissions command shown and accepted by the TUI.
  • Renamed the auto-review denial command from /autoreview to /approve.
  • Updated nearby comments so they refer to /permissions rather than the retired /approvals name.

Verification

  • Updated the slash-command unit test to assert that AutoReview now renders and parses as approve.

@etraut-openai etraut-openai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@won-openai won-openai enabled auto-merge (squash) May 4, 2026 17:39
@won-openai won-openai merged commit 5c1ec8f into main May 4, 2026
26 checks passed
@won-openai won-openai deleted the approvalremove branch May 4, 2026 17:50
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants