feat: add max_lines to memories MCP read#20991
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The memories MCP
readtool already supportsline_offset, but it cannot return a bounded line range. That makes it awkward to page through large memory files or request a small slice without relying on token truncation.What changed
max_linesparameter to the memories MCPreadtool schema and request parsingmax_lines = 0as an invalid request and surface it asinvalid_paramsTesting
memories/mcp/src/local_tests.rsformax_linesreads and invalidmax_lines/line_offsetrequests