feat: add remote compaction v2 Responses client path#20773
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68fbdc27a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fix the compact_remote_v2 lint issues and refresh generated schema fixtures. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
reviewed
May 4, 2026
aibrahim-oai
approved these changes
May 4, 2026
aibrahim-oai
left a comment
Collaborator
There was a problem hiding this comment.
Should we parametrize all compaction logic to run as v2 as well to not lose coverage in the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This adds the
remote_compaction_v2client path so remote compaction can run through the normal Responses stream and install acontext_compactionitem that trigger a compaction.The goal is to migrate some of the compaction logic on the client side
We keeps the v2 transport behind a feature flag while letting follow-up requests reuse the compacted context instead of falling back to the legacy compaction item shape.
What changed
ResponseItem::ContextCompactionand refresh the generated app-server / schema / TypeScript fixtures that expose response items on the wirecore/src/compact_remote_v2.rsto send compaction through the standard streamed Responses client, require exactly onecontext_compactionoutput item, and install that item into compacted historyremote_compaction_v2is enabled, while keeping the existing remote compaction path as the fallbackcontext_compactionserialization, rollout-trace normalization, and remote-compaction follow-up behaviorVerification
context_compactionserialization/deserialization inprotocol/src/models.rscontext_compactionnormalization inrollout-trace/src/reducer/conversation_tests.rscore/tests/suite/compact_remote.rs