Unify skip-review handling for approval_mode = "approve"#20750
Merged
Conversation
8bbb616 to
3ec1cff
Compare
3ec1cff to
6c32c4a
Compare
owenlin0
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approval_mode = "approve"as skip-review across all permission modes.Testing
just fmtcargo test -p codex-mcpcargo test -p codex-core approve_mode_skips_arc_and_guardian_in_every_permission_modegit diff --checkcargo test -p codex-corewas also attempted, but the suite hit an unrelated pre-existing stack overflow in an existing multi-agent test