Skip to content

Unify skip-review handling for approval_mode = "approve"#20750

Merged
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/unify-approve-skipreview-semantics
May 4, 2026
Merged

Unify skip-review handling for approval_mode = "approve"#20750
mzeng-openai merged 1 commit into
mainfrom
dev/mzeng/unify-approve-skipreview-semantics

Conversation

@mzeng-openai

Copy link
Copy Markdown
Collaborator

Summary

  • Treat approval_mode = "approve" as skip-review across all permission modes.
  • Remove the mode-specific split in the MCP auto-approval gate so approved tools bypass review consistently.
  • Expand regression coverage in the shared MCP helper and the core tool-call flow.

Testing

  • just fmt
  • cargo test -p codex-mcp
  • cargo test -p codex-core approve_mode_skips_arc_and_guardian_in_every_permission_mode
  • git diff --check
  • Full cargo test -p codex-core was also attempted, but the suite hit an unrelated pre-existing stack overflow in an existing multi-agent test

@mzeng-openai mzeng-openai force-pushed the dev/mzeng/unify-approve-skipreview-semantics branch 3 times, most recently from 8bbb616 to 3ec1cff Compare May 3, 2026 22:50
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/unify-approve-skipreview-semantics branch from 3ec1cff to 6c32c4a Compare May 3, 2026 23:41
@mzeng-openai mzeng-openai marked this pull request as ready for review May 4, 2026 05:37
@mzeng-openai mzeng-openai requested a review from a team as a code owner May 4, 2026 05:37
@mzeng-openai mzeng-openai merged commit 1b900be into main May 4, 2026
37 of 38 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/unify-approve-skipreview-semantics branch May 4, 2026 17:30
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants