Remove remote plugin uninstall prefix gate#20722
Merged
xli-oai merged 5 commits intoMay 4, 2026
Merged
Conversation
Contributor
Author
|
@codex review |
xl-openai
approved these changes
May 4, 2026
17c9fde to
13ca1cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the hardcoded remote plugin ID prefix allow-list from app-server uninstall routing. IDs that do not parse as local
plugin@marketplaceIDs now flow through the remote uninstall path, where the existing remote ID safety validation still rejects empty IDs, spaces, slashes, and other unsafe characters before URL/cache use.Why
Plugin-service owns the backend remote plugin ID contract. Codex should not require remote IDs to start with the local hardcoded prefixes
plugins~,plugins_,app_,asdk_app_, orconnector_, because newer backend ID families could otherwise be rejected before plugin-service sees the request.Validation
just fmtcargo test -p codex-app-server plugin_uninstalljust fix -p codex-app-servergit diff --check