feat: seed ad-hoc memory extension instructions#20606
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de0dfe629e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Ad-hoc memory notes are written under
memories/extensions/ad_hoc/, but the consolidation agent only knows how to interpret an extension when the extension folder has aninstructions.md. Seed those instructions from the memories write pipeline so an enabled memories startup creates the expected ad-hoc extension layout automatically.This also moves extension-specific write behavior behind a dedicated
memories/write/src/extensions/module.ad_hocowns the seeded instructions template, while the existing resource-retention cleanup lives in its ownprunemodule so future memory extensions can add their own write-side setup without growing a flat helper file.Changes
memories/extensions/ad_hoc/instructions.mdduring eligible memory startup without overwriting an existing file.memories/write/templates/extensions/ad_hoc/, keeping ownership incodex-memories-write.extensions::ad_hocandextensions::prune.Verification
cargo test -p codex-memories-writebazel build //codex-rs/memories/write:write