[tool_suggest] More prompt polishes.#20566
Merged
Merged
Conversation
sayan-oai
approved these changes
May 1, 2026
sayan-oai
left a comment
Collaborator
There was a problem hiding this comment.
please rename files accordingly
sayan-oai
reviewed
May 1, 2026
Collaborator
There was a problem hiding this comment.
why's this still called ToolSuggestHandler? whys the file still called tool_suggest.rs?
Collaborator
Author
There was a problem hiding this comment.
Did a larger sweep for renaming things.
sayan-oai
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool suggest still misfires when model needs tool_search, updating the prompts to further disambiguate it:
tool_suggesttorequest_plugin_installTested with the Codex App and verified it still works.