Skip to content

Alias codex_hooks feature as hooks#20522

Merged
abhinav-oai merged 1 commit into
mainfrom
abhinav/hooks-feature-alias
May 1, 2026
Merged

Alias codex_hooks feature as hooks#20522
abhinav-oai merged 1 commit into
mainfrom
abhinav/hooks-feature-alias

Conversation

@abhinav-oai

Copy link
Copy Markdown
Collaborator

Why

The hooks feature flag should use the concise canonical name hooks, while existing configs that still use codex_hooks continue to work during the rename.

What

  • change the canonical Feature::CodexHooks key from codex_hooks to hooks
  • register codex_hooks through the existing legacy-alias path
  • update the config schema and canonical config fixtures to prefer hooks
  • add regression coverage that both hooks and codex_hooks resolve to Feature::CodexHooks

Verification

  • cargo test -p codex-features
  • cargo test -p codex-core config::schema_tests
  • cargo test -p codex-core pre_tool_use_blocks_shell_when_defined_in_config_toml
  • cargo test -p codex-app-server hooks_list_uses_each_cwds_effective_feature_enablement

@abhinav-oai abhinav-oai requested a review from a team as a code owner April 30, 2026 22:59
@abhinav-oai abhinav-oai enabled auto-merge (squash) May 1, 2026 00:17
@abhinav-oai abhinav-oai merged commit 0d9a5d2 into main May 1, 2026
35 of 36 checks passed
@abhinav-oai abhinav-oai deleted the abhinav/hooks-feature-alias branch May 1, 2026 00:46
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants