Stop emitting item/fileChange/outputDelta output delta notifications#20471
Merged
Conversation
…ping # Conflicts: # codex-rs/thread-manager-sample/src/main.rs
owenlin0
approved these changes
Apr 30, 2026
…-change-output # Conflicts: # codex-rs/app-server-protocol/src/protocol/event_mapping.rs # codex-rs/app-server/src/bespoke_event_handling.rs # codex-rs/thread-manager-sample/src/main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
item/fileChange/outputDeltatext output was only the tool's summary or error text and not used by client surfaces.We keep
item/fileChange/outputDeltain the app-server protocol as a deprecated compatibility entry, but the server no longer emits it.What changed
apply_patchruntime from emittingExecCommandOutputDeltaeventsitem_event_to_server_notificationso command output deltas always map toitem/commandExecution/outputDeltaitem/fileChange/outputDeltaas a deprecated legacy protocol entry in the v2 types, schema, and READMETesting
cargo test -p codex-app-server-protocolcargo test -p codex-thread-manager-samplecargo test -p codex-app-server-protocol protocol::event_mapping::tests::exec_command_output_delta_maps_to_command_execution_output_delta -- --exactcargo test -p codex-app-server turn_start_file_change_approval_accept_for_session_persists_v2 -- --exact(failed before the test assertions because the wiremock/responsesmock received 0 requests in setup)