Move plugin out of core.#20348
Conversation
|
@codex review this PR with a focus on migration feature parity. Please verify that the behavior after the move is exactly the same as before, and flag any regressions, missing paths, or subtle API/behavior differences introduced by the migration. |
There was a problem hiding this comment.
💡 Codex Review
legacy_core::plugins compatibility re-export
app-server-client removed legacy_core::plugins::PluginsManager, which was the transitional API for consumers still using embedded-core plugin paths. This is a migration parity regression: existing callers compiling against the shim now fail and must refactor dependencies during what should be a move-only change.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fs::create_dir_all(codex_home)?; | ||
| fs::write(config_path, doc.to_string()) |
There was a problem hiding this comment.
Restore atomic writes when persisting plugin config edits
apply_user_plugin_config_edits_blocking now persists config.toml with plain fs::write, which truncates and rewrites in place. The previous path (ConfigEditsBuilder) used atomic replacement, so failures (e.g., ENOSPC/crash) could not leave a partially written config. This migration introduces a config-corruption window and weaker durability guarantees.
Useful? React with 👍 / 👎.
|
Re |
|
@codex review this PR for behavioral parity only. Treat the removed |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
left a comment
There was a problem hiding this comment.
thanks for cleaning this up 🙏
please test very thoroughly!
No description provided.