Make missing config clears no-ops#20334
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #20145.
config/value/writetreats a JSONnullvalue as a request to clear the config key. Clearing a key that is already absent should be idempotent, but clearing a nested key such asfeatures.personalityfrom an emptyconfig.tomlreturnedconfigPathNotFoundbecauseclear_pathtreated the missingfeaturesparent table as an error.That makes app-server reset flows brittle because clients have to read first and avoid sending a clear request unless the parent path already exists.
What Changed
MergeError::PathNotFoundpath from config write merging.features.personality = nullagainst an empty user config.Verification
cargo test -p codex-app-server clear_missing_nested_config_is_noopcargo test -p codex-app-serverwas run; the config manager unit suite passed, but one unrelated integration test failed becauseturn_start_emits_thread_scoped_warning_notification_for_trimmed_skillsexpected7trimmed skills and observed8.just fix -p codex-app-server