Remove core protocol dependency [1/2]#20324
Merged
Merged
Conversation
dc41aab to
e9eaab1
Compare
e9eaab1 to
d57635e
Compare
fcoury-oai
approved these changes
Apr 30, 2026
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Ran a focused local smoke test for the TUI refactor path on this PR: started the PR branch’s TUI in a disposable workspace, exercised a normal read-only turn, an approval-backed file edit through the patch/diff UI, the /status surface, and a resume flow.
Everything worked as expected. Code looks good, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This stack moves
codex-tuiaway from the core protocol event surface and toward app-server API shapes plus TUI-owned local models. This first PR sets up the lower-risk foundation: it introduces the local model surface and extracts app-server event routing into focused TUI modules while preserving the existing behavior for the larger migration in PR2.This PR is part 1 of a 2-PR stack:
What changed
app/app_server_event_targets.rsandapp/app_server_events.rsto hold app-server event targeting and dispatch logic outsideapp.rs.Verification
cargo check -p codex-tui --tests